pageinspect: Fix handling of page sizes and AM types
This commit fixes a set of issues related to the use of the SQL
functions in this module when the caller is able to pass down raw page
data as input argument:
- The page size check was fuzzy in a couple of places, sometimes
looking after only a sub-range, but what we are looking for is an exact
match on BLCKSZ. After considering a few options here, I have settled
down to do a generalization of get_page_from_raw(). Most of the SQL
functions already used that, and this is not strictly required if not
accessing an 8-byte-wide value from a raw page, but this feels safer in
the long run for alignment-picky environment, particularly if a code
path begins to access such values. This also reduces the number of
strings that need to be translated.
- The BRIN function brin_page_items() uses a Relation but it did not
check the access method of the opened index, potentially leading to
crashes. All the other functions in need of a Relation already did
that.
- Some code paths could fail on elog(), but we should to use ereport()
for failures that can be triggered by the user.
Tests are added to stress all the cases that are fixed as of this
commit, with some junk raw pages (\set VERBOSITY ensures that this works
across all page sizes) and unexpected index types when functions open
relations.
Author: Michael Paquier, Justin Prysby
Discussion: https://postgr.es/m/20220218030020.GA1137@telsasoft.com
Backpatch-through: 10
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/af8a8eb54245b2f24bbe1b93811fffbb71cca235
Modified Files
--------------
contrib/pageinspect/brinfuncs.c | 36 ++++++++++++----------------------
contrib/pageinspect/btreefuncs.c | 28 ++++++++++++--------------
contrib/pageinspect/expected/brin.out | 4 ++++
contrib/pageinspect/expected/btree.out | 15 ++++++++++++++
contrib/pageinspect/expected/gin.out | 11 +++++++++++
contrib/pageinspect/expected/hash.out | 17 ++++++++++++++++
contrib/pageinspect/expected/page.out | 11 +++++++++++
contrib/pageinspect/fsmfuncs.c | 4 +++-
contrib/pageinspect/hashfuncs.c | 6 ++++--
contrib/pageinspect/rawpage.c | 29 +++------------------------
contrib/pageinspect/sql/brin.sql | 4 ++++
contrib/pageinspect/sql/btree.sql | 13 ++++++++++++
contrib/pageinspect/sql/gin.sql | 9 +++++++++
contrib/pageinspect/sql/hash.sql | 13 ++++++++++++
contrib/pageinspect/sql/page.sql | 9 +++++++++
15 files changed, 142 insertions(+), 67 deletions(-)
