pgsql: Wake up for latches in CheckpointWriteDelay(). - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Wake up for latches in CheckpointWriteDelay().
Date
Msg-id E1nUI8A-000FWF-5o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Wake up for latches in CheckpointWriteDelay().

The checkpointer shouldn't ignore its latch.  Other backends may be
waiting for it to drain the request queue.  Hopefully real systems don't
have a full queue often, but the condition is reached easily when
shared_buffers is small.

This involves defining a new wait event, which will appear in the
pg_stat_activity view often due to spread checkpoints.

Back-patch only to 14.  Even though the problem exists in earlier
branches too, it's hard to hit there.  In 14 we stopped using signal
handlers for latches on Linux, *BSD and macOS, which were previously
hiding this problem by interrupting the sleep (though not reliably, as
the signal could arrive before the sleep begins; precisely the problem
latches address).

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/78c0f85e435bf327dcf2c1aded47b51263b32b82

Modified Files
--------------
doc/src/sgml/monitoring.sgml            | 4 ++++
src/backend/postmaster/checkpointer.c   | 8 +++++++-
src/backend/utils/activity/wait_event.c | 3 +++
src/include/utils/wait_event.h          | 3 ++-
4 files changed, 16 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Wake up for latches in CheckpointWriteDelay().
Next
From: Michael Paquier
Date:
Subject: pgsql: pageinspect: Fix handling of page sizes and AM types