pgsql: Suppress variable-set-but-not-used warning from clang 13. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Suppress variable-set-but-not-used warning from clang 13.
Date
Msg-id E1nBfS9-00058Z-Vv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: https://postgr.es/m/CA+hUKGLTSZQwES8VNPmWO9AO0wSeLt36OCPDAZTccT1h7Q7kTQ@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bd110e250e9d9291d7fc1ea12ddd5d177a2460bd

Modified Files
--------------
src/backend/optimizer/geqo/geqo_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Correct type of front_pathkey to PathKey
Next
From: Tom Lane
Date:
Subject: pgsql: Suppress variable-set-but-not-used warning from clang 13.