pgsql: Correct type of front_pathkey to PathKey - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Correct type of front_pathkey to PathKey
Date
Msg-id E1nBTJc-0008T5-Ut@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Correct type of front_pathkey to PathKey

In sort_inner_and_outer we iterate a list of PathKey elements, but the
variable is declared as (List *). This mistake is benign, because we
only pass the pointer to lcons() and never dereference it.

This exists since ~2004, but it's confusing. So fix and backpatch to all
supported branches.

Backpatch-through: 10
Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a3eb08b809a4b9e348efb0bae9c2834b71d53273

Modified Files
--------------
src/backend/optimizer/path/joinpath.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Correct type of front_pathkey to PathKey
Next
From: Tom Lane
Date:
Subject: pgsql: Suppress variable-set-but-not-used warning from clang 13.