pgsql: Fix race condition in startup progress reporting. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Fix race condition in startup progress reporting.
Date
Msg-id E1mgWrY-0001bR-5J@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix race condition in startup progress reporting.

Commit 9ce346eabf350a130bba46be3f8c50ba28506969 added startup
progress reporting, but begin_startup_progress_phase has a race
condition: the timeout for the previous phase might fire just
before we reschedule the interrupt for the next phase.

To avoid the race, disable the timeout, clear the flag, and then
re-enable the timeout.

Patch by me, reviewed by Nitin Jadhav.

Discussion: https://postgr.es/m/CA+TgmoYq38i6iAzfRLVxA6Cm+wMCf4WM8wC3o_a+X_JvWC8bJg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5ccceb2946d4104804f8dca67515b602f5e78cdd

Modified Files
--------------
src/backend/postmaster/startup.c | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: When fetching WAL for a basebackup, report errors with a sensibl
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Report progress of startup operations that take a long time.