pgsql: Check for fseeko() failure in pg_dump's _tarAddFile(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().
Date
Msg-id E1k4oM7-0004Mf-KF@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Check for fseeko() failure in pg_dump's _tarAddFile().

Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these.  Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem.  Still, that's a
poor excuse for not checking the result of a system call.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/26037705159489aff046d93227ab469d71616baf

Modified Files
--------------
src/bin/pg_dump/pg_backup_tar.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove useless Assert.
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Correct nbtree page split lock coupling comment.