pgsql: Remove useless Assert. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove useless Assert.
Date
Msg-id E1k4nJR-0003wu-AB@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove useless Assert.

Testing that an unsigned variable is >= 0 is pretty pointless,
as noted by Coverity and numerous buildfarm members.

In passing, add comment about new uses of "volatile" --- Coverity
doesn't much like that either, but it seems probably necessary.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1c164ef3d28dfab445a885a03e80cfd0d552f64a

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Release notes for 12.4, 11.9, 10.14, 9.6.19, 9.5.23.
Next
From: Tom Lane
Date:
Subject: pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().