pgAdmin 4 commit: Fixed following SonarQube issues: - Mailing list pgadmin-hackers

Fixed following SonarQube issues:
  - Refactor functions to not always return the same value.
  - Rename "cls" to "self" or add the missing "self" parameter.
  - Remove useless assignment to variables.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56cf64ad221d63c200d39ab2b9fcddcc22c0c1c5
Author: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>

Modified Files
--------------
web/pgadmin/authenticate/registry.py               |   6 +-
.../static/js/fts_configuration.js                 |  59 +--
.../check_constraint/static/js/check_constraint.js |  44 +-
.../static/js/exclusion_constraint.js              |  56 +-
.../foreign_key/static/js/foreign_key.js           |  82 ++-
.../servers/databases/static/js/database.js        |  98 ++--
.../servers/pgagent/static/js/pga_job.js           |  27 +-
.../server_groups/servers/static/js/server.js      | 572 ++++++++++-----------
web/pgadmin/browser/static/js/browser.js           |   1 -
web/pgadmin/browser/static/js/datamodel.js         | 244 ++++-----
web/pgadmin/preferences/static/js/preferences.js   |   6 +-
.../tools/import_export/static/js/import_export.js |   1 -
web/pgadmin/tools/sqleditor/command.py             |   6 +-
.../user_management/static/js/user_management.js   |  27 +-
web/pgadmin/utils/driver/psycopg2/__init__.py      |   4 +-
web/pgadmin/utils/driver/registry.py               |   6 +-
web/pgadmin/utils/route.py                         |   8 +-
17 files changed, 604 insertions(+), 643 deletions(-)