Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Function returns same value - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][SonarQube] Function returns same value
Date
Msg-id CANxoLDeACP55McdfdJZYQ-FxbVqGuVMSqtDaRYeBPstjjzWq7A@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][SonarQube] Function returns same value  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Thu, Jul 30, 2020 at 1:09 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
- Refactor functions to not always return the same value
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables
And a minor UI foreign key dialog add columns.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed following SonarQube issues:
Next
From: Aditya Toshniwal
Date:
Subject: Re: WIP: SQL Formatter