pgsql: Don't call elog() while holding spinlock. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Don't call elog() while holding spinlock.
Date
Msg-id E1jg44L-0006FF-2f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't call elog() while holding spinlock.

Previously UpdateSpillStats() called elog(DEBUG2) while holding
the spinlock even though the local variables that the elog() accesses
don't need to be protected by the lock. Since spinlocks are intended
for very short-term locks, they should not be used when calling
elog(DEBUG2). So this commit moves that elog() out of spinlock period.

Author: Kyotaro Horiguchi
Reviewed-by: Amit Kapila and Fujii Masao
Discussion: https://postgr.es/m/20200602.161518.1399689010416646074.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/caa3c4242cf86322e2ed0c86199e6462a2c41565

Modified Files
--------------
src/backend/replication/walsender.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Doc: Update the documentation for spilled transaction statistics
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql: doc: make ref/*.sgml file header comment layout consistent