pgsql: Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES c - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES c
Date
Msg-id E1jNLPA-00013g-W3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES code.

The placement of the fall-through comment in this code appears not to
work to suppress the warning in recent gcc.  Move it to the bottom of
the case group, and add an assertion that we didn't get there through
some other code path.  Also improve wording of nearby comments.

Julien Rouhaud, comment hacking by me

Discussion: https://postgr.es/m/CAOBaU_aLdPGU5wCpaowNLF-Q8328iR7mj1yJAhMOVsdLwY+sdg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/35cb574aa84723f4661e9fc51340130e64cb5dfc

Modified Files
--------------
src/backend/executor/nodeLimit.c | 33 +++++++++++++++++++--------------
1 file changed, 19 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Support FETCH FIRST WITH TIES
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Doc: Fix contrib/amcheck tip.