pgsql: Stabilize incremental_sort tests - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Stabilize incremental_sort tests
Date
Msg-id E1jMDmJ-0000HM-8w@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Stabilize incremental_sort tests

The test never did ANALYZE on the test table, so the plans depended on
various defaults (e.g. number of groups being 200). This worked most of
the time, but with CLOBBER_CACHE_ALWAYS the autoanalyze often managed
to build accurate stats, changing the  plan.

Fixed by increasing the size of test tables a bit, making the Sort a bit
more expensive than Incremental Sort. The tests were constructed to test
transitions in the Incremental Sort algorithm, and this change does not
break that.

Reviewed-by: James Coleman
Discussion: https://postgr.es/m/CAPpHfds1waRZ=NOmueYq0sx1ZSCnt+5QJvizT8ndT2=etZEeAQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cea09246e57821b8a97a6483a7df6c7345b055ef

Modified Files
--------------
src/test/regress/expected/incremental_sort.out | 32 +++++++++++++++-----------
src/test/regress/sql/incremental_sort.sql      | 15 ++++++++----
2 files changed, 29 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: createuser: Change a fprintf to pg_log_error