pgsql: Fix fuzzy error handling in pg_basebackup when opening gzFile - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix fuzzy error handling in pg_basebackup when opening gzFile
Date
Msg-id E1iyqHe-0005i0-6U@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix fuzzy error handling in pg_basebackup when opening gzFile

First, this code did not bother checking for a failure when calling
dup().  Then, per zlib, gzerror() returns NULL for a NULL input, which
can happen if passing down to gzdopen() an invalid file descriptor or if
there was an allocation failure.

No back-patch is done as this would unlikely be a problem in the field.

Per Coverity.

Reported-by: Tom Lane

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/177be9edf4bb966400db7769d61e479aa0fe0201

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Add missing break out seqscan loop in logical replication
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Handle lack of DSM slots in parallel btree build.