pgsql: Handle ReadFile() EOF correctly on Windows. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Handle ReadFile() EOF correctly on Windows.
Date
Msg-id E1iXIbb-00040g-3r@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Handle ReadFile() EOF correctly on Windows.

When ReadFile() encounters the end of a file while reading from
a synchronous handle with an offset provided via OVERLAPPED, it
reports an error instead of returning 0.  By not handling that
(undocumented) result correctly, we caused some noisy LOG
messages about an unknown error code.  Repair.

Back-patch to 12, where we started using pread()/ReadFile() with
an offset.

Reported-by: ZhenHua Cai, Amit Kapila
Diagnosed-by: Juan Jose Santamaria Flecha
Tested-by: Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1LK3%2BWRtpz68TiRdpHwxxWm%3D%2Bt1BMf-G68hhQsAQ41PZg%40mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2189f49c420f2bf49dfac122f9fbae51c3565594

Modified Files
--------------
src/port/pread.c | 3 +++
1 file changed, 3 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Handle ReadFile() EOF correctly on Windows.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix comment in xact.h