pgsql: In PQprint(),write HTML table trailer before closing the output - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: In PQprint(),write HTML table trailer before closing the output
Date
Msg-id E1gVKb8-0002yZ-Cr@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
In PQprint(), write HTML table trailer before closing the output pipe.

This is an astonishingly ancient bit of silliness, dating AFAICS to
commit edb519b14 of 27-Jul-1996 which added the pipe close stanza in
the wrong place.  It happens to be harmless given that the code above
this won't enable the pager if html3 output mode is selected.  Still,
somebody might try to relax that restriction someday, and in any case
it could confuse readers and static analysis tools, so let's fix it in
HEAD.

Per bug #15541 from Pan Bian.

Discussion: https://postgr.es/m/15541-c835d8b9a903f7ad@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b90e6cef12662ccad8679be24cd650c6b49feb1c

Modified Files
--------------
src/interfaces/libpq/fe-print.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: document that we expect CHECK constraint conditions to bei