[COMMITTERS] pgsql: Speedup pgstat_report_activity by moving mb-aware truncationto - Mailing list pgsql-committers

From Andres Freund
Subject [COMMITTERS] pgsql: Speedup pgstat_report_activity by moving mb-aware truncationto
Date
Msg-id E1duOkJ-0001Mc-U5@gemulon.postgresql.org
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Speedup pgstat_report_activity by moving mb-aware truncation to  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Speedup pgstat_report_activity by moving mb-aware truncation to read side.

Previously multi-byte aware truncation was done on every
pgstat_report_activity() call - proving to be a bottleneck for
workloads with long query strings that execute quickly.

Instead move the truncation to the read side, which commonly is
executed far less frequently. That's possible because all server
encodings allow to determine the length of a multi-byte string from
the first byte.

Rename PgBackendStatus.st_activity to st_activity_raw so existing
extension users of the field break - their code has to be adjusted to
use pgstat_clip_activity().

Author: Andres Freund
Tested-By: Khuntal Ghosh
Reviewed-By: Robert Haas, Tom Lane
Discussion: https://postgr.es/m/20170912071948.pa7igbpkkkviecpz@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/54b6cd589ac2f5635a42511236a5eb7299e2dcaf

Modified Files
--------------
src/backend/postmaster/pgstat.c     | 63 ++++++++++++++++++++++++++++---------
src/backend/utils/adt/pgstatfuncs.c | 17 +++++++---
src/include/pgstat.h                | 12 +++++--
3 files changed, 72 insertions(+), 20 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: [COMMITTERS] pgsql: Disable multi-byte citext tests
Next
From: Andres Freund
Date:
Subject: Re: [COMMITTERS] pgsql: Make new crash restart test a bit morerobust.