Re: [COMMITTERS] pgsql: Make new crash restart test a bit morerobust. - Mailing list pgsql-committers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: Make new crash restart test a bit morerobust.
Date
Msg-id 20170919202518.au4ngniiwdsyewbp@alap3.anarazel.de
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Make new crash restart test a bit more robust.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Make new crash restart test a bit more robust.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2017-09-19 15:24:49 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Checkining on calliphoridae why that's not sufficient - the machine's
> > busy, so the build & test will take a bit.
> 
> FWIW, prairiedog got through the recovery tests this time --- run's
> still going though.

So this is geniuinely interesting. When the machine is really loaded (as
in 6 animals running on a vm at the same time, incuding valgrind), psql
sometimes doesn't get the WARNING message from a shutdown. Instead it
gets
# psql:<stdin>:3: server closed the connection unexpectedly
#       This probably means the server terminated abnormally
#       before or while processing the request.
# psql:<stdin>:3: connection to server was lost

We can obviously easily make the test accept both - but are we ok with
the client sometimes not getting the message?

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Speedup pgstat_report_activity by moving mb-aware truncationto
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Speedup pgstat_report_activity by moving mb-aware truncation to