[COMMITTERS] pgsql: Throw suitable error for COPY TO STDOUT/FROM STDIN in a SQLfunc - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Throw suitable error for COPY TO STDOUT/FROM STDIN in a SQLfunc
Date
Msg-id E1cST3k-0004fR-1A@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Throw suitable error for COPY TO STDOUT/FROM STDIN in a SQL function.

A client copy can't work inside a function because the FE/BE wire protocol
doesn't support nesting of a COPY operation within query results.  (Maybe
it could, but the protocol spec doesn't suggest that clients should support
this, and libpq for one certainly doesn't.)

In most PLs, this prohibition is enforced by spi.c, but SQL functions don't
use SPI.  A comparison of _SPI_execute_plan() and init_execution_state()
shows that rejecting client COPY is the only discrepancy in what they
allow, so there's no other similar bugs.

This is an astonishingly ancient oversight, so back-patch to all supported
branches.

Report: https://postgr.es/m/BY2PR05MB2309EABA3DEFA0143F50F0D593780@BY2PR05MB2309.namprd05.prod.outlook.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/75abb955dfef064f2fbc5c043f37fff8d0262ffe

Modified Files
--------------
src/backend/executor/functions.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: [COMMITTERS] pgsql: Change default values for backup and replication parameters
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Change representation of statement lists,and add statement loca