[COMMITTERS] pgsql: Change representation of statement lists,and add statement loca - Mailing list pgsql-committers

Change representation of statement lists, and add statement location info.

This patch makes several changes that improve the consistency of
representation of lists of statements.  It's always been the case
that the output of parse analysis is a list of Query nodes, whatever
the types of the individual statements in the list.  This patch brings
similar consistency to the outputs of raw parsing and planning steps:

* The output of raw parsing is now always a list of RawStmt nodes;
the statement-type-dependent nodes are one level down from that.

* The output of pg_plan_queries() is now always a list of PlannedStmt
nodes, even for utility statements.  In the case of a utility statement,
"planning" just consists of wrapping a CMD_UTILITY PlannedStmt around
the utility node.  This list representation is now used in Portal and
CachedPlan plan lists, replacing the former convention of intermixing
PlannedStmts with bare utility-statement nodes.

Now, every list of statements has a consistent head-node type depending
on how far along it is in processing.  This allows changing many places
that formerly used generic "Node *" pointers to use a more specific
pointer type, thus reducing the number of IsA() tests and casts needed,
as well as improving code clarity.

Also, the post-parse-analysis representation of DECLARE CURSOR is changed
so that it looks more like EXPLAIN, PREPARE, etc.  That is, the contained
SELECT remains a child of the DeclareCursorStmt rather than getting flipped
around to be the other way.  It's now true for both Query and PlannedStmt
that utilityStmt is non-null if and only if commandType is CMD_UTILITY.
That allows simplifying a lot of places that were testing both fields.
(I think some of those were just defensive programming, but in many places,
it was actually necessary to avoid confusing DECLARE CURSOR with SELECT.)

Because PlannedStmt carries a canSetTag field, we're also able to get rid
of some ad-hoc rules about how to reconstruct canSetTag for a bare utility
statement; specifically, the assumption that a utility is canSetTag if and
only if it's the only one in its list.  While I see no near-term need for
relaxing that restriction, it's nice to get rid of the ad-hocery.

The API of ProcessUtility() is changed so that what it's passed is the
wrapper PlannedStmt not just the bare utility statement.  This will affect
all users of ProcessUtility_hook, but the changes are pretty trivial; see
the affected contrib modules for examples of the minimum change needed.
(Most compilers should give pointer-type-mismatch warnings for uncorrected
code.)

There's also a change in the API of ExplainOneQuery_hook, to pass through
cursorOptions instead of expecting hook functions to know what to pick.
This is needed because of the DECLARE CURSOR changes, but really should
have been done in 9.6; it's unlikely that any extant hook functions
know about using CURSOR_OPT_PARALLEL_OK.

Finally, teach gram.y to save statement boundary locations in RawStmt
nodes, and pass those through to Query and PlannedStmt nodes.  This allows
more intelligent handling of cases where a source query string contains
multiple statements.  This patch doesn't actually do anything with the
information, but a follow-on patch will.  (Passing this information through
cleanly is the true motivation for these changes; while I think this is all
good cleanup, it's unlikely we'd have bothered without this end goal.)

catversion bump because addition of location fields to struct Query
affects stored rules.

This patch is by me, but it owes a good deal to Fabien Coelho who did
a lot of preliminary work on the problem, and also reviewed the patch.

Discussion: https://postgr.es/m/alpine.DEB.2.20.1612200926310.29821@lancre

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ab1f0c8225714aaa18d2f9ca4f80cd009f145421

Modified Files
--------------
contrib/pg_stat_statements/pg_stat_statements.c |  14 +-
contrib/sepgsql/hooks.c                         |   7 +-
src/backend/catalog/pg_proc.c                   |   2 +-
src/backend/commands/copy.c                     |  39 +++--
src/backend/commands/createas.c                 |   2 +-
src/backend/commands/explain.c                  |  46 ++++--
src/backend/commands/extension.c                |  22 +--
src/backend/commands/foreigncmds.c              |  14 +-
src/backend/commands/portalcmds.c               |  50 +++++--
src/backend/commands/prepare.c                  |  34 +++--
src/backend/commands/schemacmds.c               |  21 ++-
src/backend/commands/tablecmds.c                |   3 +-
src/backend/commands/trigger.c                  |  10 +-
src/backend/commands/view.c                     |  15 +-
src/backend/executor/execParallel.c             |   4 +-
src/backend/executor/functions.c                |  92 ++++++------
src/backend/executor/spi.c                      |  55 +++----
src/backend/nodes/copyfuncs.c                   |  21 ++-
src/backend/nodes/equalfuncs.c                  |  15 ++
src/backend/nodes/outfuncs.c                    |   7 +-
src/backend/nodes/readfuncs.c                   |   7 +-
src/backend/optimizer/plan/planner.c            |  11 +-
src/backend/optimizer/prep/prepjointree.c       |   6 +-
src/backend/optimizer/util/clauses.c            |   4 +-
src/backend/parser/analyze.c                    |  88 ++++++-----
src/backend/parser/gram.y                       |  58 +++++++-
src/backend/parser/parse_clause.c               |   7 +-
src/backend/parser/parse_expr.c                 |   7 +-
src/backend/parser/parse_type.c                 |   2 +-
src/backend/parser/parser.c                     |   3 +-
src/backend/rewrite/rewriteDefine.c             |   3 +-
src/backend/tcop/postgres.c                     |  99 ++++++------
src/backend/tcop/pquery.c                       | 132 +++++++---------
src/backend/tcop/utility.c                      | 190 ++++++++++++++----------
src/backend/utils/cache/plancache.c             |  60 +++++---
src/backend/utils/mmgr/portalmem.c              |  37 ++---
src/include/catalog/catversion.h                |   2 +-
src/include/commands/copy.h                     |   3 +-
src/include/commands/explain.h                  |   1 +
src/include/commands/portalcmds.h               |   2 +-
src/include/commands/prepare.h                  |   3 +-
src/include/commands/schemacmds.h               |   3 +-
src/include/commands/view.h                     |   3 +-
src/include/executor/execdesc.h                 |   9 +-
src/include/nodes/nodes.h                       |   1 +
src/include/nodes/parsenodes.h                  |  65 ++++++--
src/include/nodes/plannodes.h                   |  15 +-
src/include/parser/analyze.h                    |   8 +-
src/include/tcop/tcopprot.h                     |   5 +-
src/include/tcop/utility.h                      |   8 +-
src/include/utils/plancache.h                   |  12 +-
src/include/utils/portal.h                      |   5 +-
src/pl/plpgsql/src/pl_exec.c                    |   3 +-
53 files changed, 788 insertions(+), 547 deletions(-)