pgsql: Allow contrib/file_fdw to read from a program, like COPY FROM PR - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Allow contrib/file_fdw to read from a program, like COPY FROM PR
Date
Msg-id E1bpfCO-0002B9-Ns@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow contrib/file_fdw to read from a program, like COPY FROM PROGRAM.

This patch just exposes COPY's FROM PROGRAM option in contrib/file_fdw.
There don't seem to be any security issues with that that are any worse
than what already exist with file_fdw and COPY; as in the existing cases,
only superusers are allowed to control what gets executed.

A regression test case might be nice here, but choosing a 100% portable
command to run is hard.  (We haven't got a test for COPY FROM PROGRAM
itself, either.)

Corey Huinker and Adam Gomaa, reviewed by Amit Langote

Discussion: <CADkLM=dGDGmaEiZ=UDepzumWg-CVn7r8MHPjr2NArj8S3TsROQ@mail.gmail.com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8e91e12bc3af85ba2287866669268f6825d2cc03

Modified Files
--------------
contrib/file_fdw/file_fdw.c             | 131 +++++++++++++++++++++-----------
contrib/file_fdw/output/file_fdw.source |   6 +-
doc/src/sgml/file-fdw.sgml              |  66 +++++++++++-----
3 files changed, 137 insertions(+), 66 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Move fsync routines of initdb into src/common/
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Move fsync routines of initdb into src/common/