Re: pgsql: Move fsync routines of initdb into src/common/ - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move fsync routines of initdb into src/common/
Date
Msg-id 19159.1475173805@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Move fsync routines of initdb into src/common/  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> Move fsync routines of initdb into src/common/

This patch is giving me compiler warnings.

file_utils.c: In function 'fsync_pgdata':
file_utils.c:86: warning: passing argument 2 of 'walkdir' from incompatible pointer type
file_utils.c:36: note: expected 'int (*)(const char *, bool,  const char *)' but argument is of type 'void (*)(const
char*, bool,  const char *)' 
file_utils.c:88: warning: passing argument 2 of 'walkdir' from incompatible pointer type
file_utils.c:36: note: expected 'int (*)(const char *, bool,  const char *)' but argument is of type 'void (*)(const
char*, bool,  const char *)' 
file_utils.c:89: warning: passing argument 2 of 'walkdir' from incompatible pointer type
file_utils.c:36: note: expected 'int (*)(const char *, bool,  const char *)' but argument is of type 'void (*)(const
char*, bool,  const char *)' 

gcc version 4.4.7 20120313 (Red Hat 4.4.7-17) (GCC)

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Allow contrib/file_fdw to read from a program, like COPY FROM PR
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix compiler warnings