pgsql: Still another try at fixing scanjoin_target insertion into paral - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Still another try at fixing scanjoin_target insertion into paral
Date
Msg-id E1bE7sT-000098-34@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Still another try at fixing scanjoin_target insertion into parallel plans.

The previous code neglected the fact that the scanjoin_target might
carry sortgroupref labelings that we need to absorb.  Instead, do
create_projection_path() unconditionally, and tweak the path's cost
estimate after the fact.  (I'm now convinced that we ought to refactor
the way we account for sometimes not needing a separate projection step,
but right now is not the time for that sort of cleanup.)

Problem identified by Amit Kapila, patch by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/598aa194af2fb7f294ae4b029494a134a44be333

Modified Files
--------------
src/backend/optimizer/plan/planner.c          | 39 ++++++++++++++-------------
src/test/regress/expected/select_parallel.out | 18 ++++++++++++-
src/test/regress/sql/select_parallel.sql      |  6 ++++-
3 files changed, 43 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Try again to fix the way the scanjoin_target is used with partia