Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Try again to fix the way the scanjoin_target is used with partia - Mailing list pgsql-committers

From Amit Kapila
Subject Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Date
Msg-id CAA4eK1+S5KXVFHgeNzEqZU-jDR62uGMUkL-iFNA6KApySP2uUA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Try again to fix the way the scanjoin_target is used with partia  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Try again to fix the way the scanjoin_target is used with partia  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view
On Sat, Jun 18, 2016 at 8:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > Patch fixing the failures along with a new test case is attached with this
> > mail
>
> That can't possibly be right, because the PathTarget.sortgrouprefs field
> is not a pointer to a Node.
>

Right.
 
>
> I think the two lines in question are just a poorly-thought-through case
> of premature optimization.  If removing them makes the failures go away
> for me, that's what I plan to do.
>

That should make the failure go-away.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Next
From: Tom Lane
Date:
Subject: pgsql: Still another try at fixing scanjoin_target insertion into paral