pgsql: Don't cache per-group context across the whole query in ordereds - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Don't cache per-group context across the whole query in ordereds
Date
Msg-id E1X2pmq-0002V4-Hs@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't cache per-group context across the whole query in orderedsetaggs.c.

Although nodeAgg.c currently uses the same per-group memory context for
all groups of a query, that might change in future.  Avoid assuming it.
This costs us an extra AggCheckCallContext() call per group, but that's
pretty cheap and is probably good from a safety standpoint anyway.

Back-patch to 9.4 in case any third-party code copies this logic.

Andrew Gierth

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ecd657974478fc713fdc3a625d648cd6a985e3e6

Modified Files
--------------
src/backend/utils/adt/orderedsetaggs.c |   28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar
Next
From: Tom Lane
Date:
Subject: pgsql: Don't cache per-group context across the whole query in ordereds