pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar
Date
Msg-id E1X2pSJ-0002B9-By@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Redesign API presented by nodeAgg.c for ordered-set and similar aggregates.

The previous design exposed the input and output ExprContexts of the
Agg plan node, but work on grouping sets has suggested that we'll regret
doing that.  Instead provide more narrowly-defined APIs that can be
implemented in multiple ways, namely a way to get a short-term memory
context and a way to register an aggregate shutdown callback.

Back-patch to 9.4 where the bad APIs were introduced, since we don't
want third-party code using these APIs and then having to change in 9.5.

Andrew Gierth

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f688cf548b3e37991009b7a3607171242c796e62

Modified Files
--------------
src/backend/executor/nodeAgg.c         |   38 +++++++++++++++++++++-----------
src/backend/utils/adt/orderedsetaggs.c |   16 ++++----------
src/include/fmgr.h                     |    8 ++++---
3 files changed, 34 insertions(+), 28 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Redesign API presented by nodeAgg.c for ordered-set and similar
Next
From: Tom Lane
Date:
Subject: pgsql: Don't cache per-group context across the whole query in ordereds