pgsql: Fix WAL replay of locking an updated tuple - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix WAL replay of locking an updated tuple
Date
Msg-id E1WJ20J-00080B-6I@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix WAL replay of locking an updated tuple  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Fix WAL replay of locking an updated tuple

We were resetting the tuple's HEAP_HOT_UPDATED flag as well as t_ctid on
WAL replay of a tuple-lock operation, which is incorrect when the tuple
is already updated.

Back-patch to 9.3.  The clearing of both header elements was there
previously, but since no update could be present on a tuple that was
being locked, it was harmless.

Bug reported by Peter Geoghegan and Greg Stark in
CAM3SWZTMQiCi5PV5OWHb+bYkUcnCk=O67w0cSswPvV7XfUcU5g@mail.gmail.com and
CAM-w4HPTOeMT4KP0OJK+mGgzgcTOtLRTvFZyvD0O4aH-7dxo3Q@mail.gmail.com
respectively; diagnosis by Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6bfa88acd3df830a5f7e8677c13512b1b50ae813

Modified Files
--------------
src/backend/access/heap/heapam.c |   14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix WAL replay of locking an updated tuple
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix WAL replay of locking an updated tuple