Re: pgsql: Fix WAL replay of locking an updated tuple - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix WAL replay of locking an updated tuple
Date
Msg-id 30633.1393512063@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix WAL replay of locking an updated tuple  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Fix WAL replay of locking an updated tuple  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: pgsql: Fix WAL replay of locking an updated tuple  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix WAL replay of locking an updated tuple

The test added by this patch certainly looks like it's backwards.
Shouldn't you be clearing HOT_UPDATED only if the tuple is *not*
XMAX_IS_LOCKED_ONLY?

If the code is actually correct as written, then I think that test
macro is very unfortunately named.

            regards, tom lane


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix WAL replay of locking an updated tuple
Next
From: Alvaro Herrera
Date:
Subject: pgsql: doc: bgw_main takes a Datum argument, not void *.