pgsql: Avoid repeated creation/freeing of per-subre DFAs during regex s - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid repeated creation/freeing of per-subre DFAs during regex s
Date
Msg-id E1S14ky-0004cH-TK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid repeated creation/freeing of per-subre DFAs during regex search.

In nested sub-regex trees, lower-level nodes created DFAs and then
destroyed them again before exiting, which is a bit dumb considering that
the recursive search is likely to call those nodes again later.  Instead
cache each created DFA until the end of pg_regexec().  This is basically a
space for time tradeoff, in that it might increase the maximum memory
usage.  However, in most regex patterns there are not all that many subre
nodes, so not that many DFAs --- and in any case, the peak usage occurs
when reaching the bottom recursion level, and except for alternation cases
that's going to be the same anyway.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/587359479acbbdc95c8e37da40707e37097423f5

Modified Files
--------------
src/backend/regex/regexec.c |  158 ++++++++++++++++++-------------------------
src/include/regex/regguts.h |    4 +-
2 files changed, 68 insertions(+), 94 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Mention original ctags option name.
Next
From: Tom Lane
Date:
Subject: pgsql: Remove useless "retry memory" logic within regex engine.