Re: [HACKERS] initdb / pg_version - Mailing list pgsql-hackers

From Patrick Welche
Subject Re: [HACKERS] initdb / pg_version
Date
Msg-id E11yIRR-0001u1-00@quartz.newn.cam.ac.uk
Whole thread Raw
In response to Re: [HACKERS] initdb / pg_version  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> 
> The dependency on a phony submake target is the problem;
> need to put in real dependencies for version.o instead.
> Might be easier if version.c were removed from .../utils
> and put in bin/pg_version.

Agreed, though not sure what is best. utils/version.c defines
 ValidatePgVersion SetPgVersion

exported in include/version.h. The only source files which reference them
are:

backend/postmaster/postmaster.c uses ValidatePgVersion
bin/pg_version/pg_version.c     uses SetPgVersion
backend/utils/init/postinit.c   uses ValidatePgVersion

Now, postmaster and postinit don't have the same problem as pg_version
as they both link against SUBSYS.o rather than version.o. I also note that
there are lots of mentions of version.o in backend/Makefile that I don't
follow.

Cheers,

Patrick


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] dumpall prob
Next
From: "Patrick Welche"
Date:
Subject: Re: [HACKERS] dumpall prob