pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ? - Mailing list pgadmin-support

hello there,

I just ran the static analyser "cppcheck" over
the source code of pgadmin3-1.18.1. It said
many things, including

1

> [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on
bothsides of '!='. 

Source code is

 if(baseUkIdxSourceCol != baseUkIdxSourceCol)

Suggest code rework.

2.

> [dd/ddmodel/ddDBReverseEnginering.cpp:1136] -> [dd/ddmodel/ddDBReverseEnginering.cpp:1136]: (style) Same expression
onboth sides of '!='. 

Duplicate.

Regards

David Binderman