Re: pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ? - Mailing list pgadmin-support

Thanks David. Guillaume, any chance you can take a look at this
please? I'm not at all familiar with that code, and I'm not entirely
sure what it's supposed to be doing.

Thanks.

On Fri, Dec 6, 2013 at 5:56 PM, David Binderman <dcb314@hotmail.com> wrote:
> hello there,
>
> I just ran the static analyser "cppcheck" over
> the source code of pgadmin3-1.18.1. It said
> many things, including
>
> 1
>
>> [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on
bothsides of '!='.
 
>
> Source code is
>
>  if(baseUkIdxSourceCol != baseUkIdxSourceCol)
>
> Suggest code rework.
>
> 2.
>
>> [dd/ddmodel/ddDBReverseEnginering.cpp:1136] -> [dd/ddmodel/ddDBReverseEnginering.cpp:1136]: (style) Same expression
onboth sides of '!='.
 
>
> Duplicate.
>
> Regards
>
> David Binderman
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company