Postgres Pro
Downloads
Home   >   mailing lists

[PATCH] Use RelationClose rather than table_close in heap_create_with_catalog - Mailing list pgsql-hackers

From Xiaoran Wang
Subject [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Date
Msg-id DS0PR05MB968933DCAB6EC48776102A7BBA829@DS0PR05MB9689.namprd05.prod.outlook.com
Whole thread Raw
Responses Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (tender wang <tndrwang@gmail.com>)
Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view
Hi hackers,

 In heap_create_with_catalog, the Relation new_rel_desc is created 
by RelationBuildLocalRelation, not table_open. So it's better to 
call RelationClose to release it.

What's more, the comment for it seems useless, just delete it.

Thanks!
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: logical decoding and replication of sequences, take 2
Next
From: vignesh C
Date:
Subject: Re: Allow logical replication to copy tables in binary format