Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog - Mailing list pgsql-hackers

From tender wang
Subject Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Date
Msg-id CAHewXNkhCBfit7ufCSaRPkqcUDhO-6W5RNyQdwooqE72v3mJtQ@mail.gmail.com
Whole thread Raw
In response to [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (Xiaoran Wang <wxiaoran@vmware.com>)
Responses Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (Xiaoran Wang <wxiaoran@vmware.com>)
List pgsql-hackers
Tree view


Xiaoran Wang <wxiaoran@vmware.com> 于2023年3月18日周六 15:04写道：
Hi hackers,

 In heap_create_with_catalog, the Relation new_rel_desc is created 
by RelationBuildLocalRelation, not table_open. So it's better to 
call RelationClose to release it.
Why it's better to call RelationClose? Is there a problem if using table_close()? 
What's more, the comment for it seems useless, just delete it.

Thanks!

regard, tender wang 

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add LZ4 compression in pg_dump
Next
From: Thomas Munro
Date:
Subject: Unlinking Parallel Hash Join inner batch files sooner