Re: Making background psql nicer to use in tap tests - Mailing list pgsql-hackers

> On 2 Apr 2023, at 23:37, Andres Freund <andres@anarazel.de> wrote:

> There's this XXX that I added:
> 
>> @@ -57,11 +51,10 @@ sub test_streaming
>>     COMMIT;
>>     });
>> 
>> -    $in .= q{
>> -    COMMIT;
>> -    \q
>> -    };
>> -    $h->finish;    # errors make the next test fail, so ignore them here
>> +    $h->query_safe('COMMIT');
>> +    $h->quit;
>> +    # XXX: Not sure what this means
>> +    # errors make the next test fail, so ignore them here
>> 
>>     $node_publisher->wait_for_catchup($appname);
> 
> I still don't know what that comment is supposed to mean, unfortunately.

My reading of it is that it's ignoring any croak errors which IPC::Run might
throw if ->finish() isn't able to reap the psql process which had the \q.

I've added Amit who committed it in 216a784829c on cc: to see if he remembers
the comment in question and can shed some light.  Skimming the linked thread
yields no immediate clues.

--
Daniel Gustafsson