Re: Making background psql nicer to use in tap tests - Mailing list pgsql-hackers

Hi,

On 2023-04-02 22:24:16 +0200, Daniel Gustafsson wrote:
> And a v5 to fix a test failure in recovery tests.

Thanks for workin gon this!


There's this XXX that I added:

> @@ -57,11 +51,10 @@ sub test_streaming
>      COMMIT;
>      });
>  
> -    $in .= q{
> -    COMMIT;
> -    \q
> -    };
> -    $h->finish;    # errors make the next test fail, so ignore them here
> +    $h->query_safe('COMMIT');
> +    $h->quit;
> +    # XXX: Not sure what this means
> +    # errors make the next test fail, so ignore them here
>  
>      $node_publisher->wait_for_catchup($appname);

I still don't know what that comment is supposed to mean, unfortunately.

Greetings,

Andres Freund