On Jan 9, 2019, at 4:47 PM, Michael Paquier <michael@paquier.xyz> wrote:
> That's much cleaner to me to clean up the field for safety before
> starting the process. When requesting a WAL receiver to start,
> slotname and conninfo gets zeroed before doing anything, you are right
> that we could do without it actually.
Cool! I agree that cleaning up the field would make the logic cleaner.
> That's a pattern used quite a lot for many GUCs, so that's quite
> separate from this patch. Perhaps it would make sense to have a macro
> for that purpose for GUCs, I am not sure if that's worth it though.
Yeah. I think having such macro would make the code a bit cleaner. Tho the
duplication of logic is not too significant.
