RE: [PATCH] Windows port add support to BCryptGenRandom - Mailing list pgsql-hackers

Enviadas: Quarta-feira, 18 de Dezembro de 2019 02:19
>This looks like a leftover of d9dd406, which has made the code to
>require C99.  As we don't support compilation with Windows XP and
>require Windows 7, we should be able to remove all the dance around
>MIN_WINNT in win32.h, don't you think?
It would be a good thing since there is no support for these old systems.
And whenever there is a patch that touches windows, someone could complain that it would be breaking something.

Can You help improve the support of BCryptoGenRandom?
I still have doubts about:

1. This break MingW?
2. Legacy API, have to stay?
3. Perl support, pgbench specifically.

If legacy API, have to stay, I have no doubt that it needs to be guarded by conditionals.

Best regards,

Ranier Vilela

1.