Re: Dimension limit in contrib/cube (dump/restore hazard?) - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Dimension limit in contrib/cube (dump/restore hazard?)
Date
Msg-id CAPpHfdtUUhuQPCqi-NHt7Z8-GM+2uXRQvNZxWqeuzqkYz=31VA@mail.gmail.com
Whole thread Raw
In response to Re: Dimension limit in contrib/cube (dump/restore hazard?)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Aug 30, 2018 at 4:59 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> > I'm going to check this patchset on Windows and commit if no objections.
>
> These error messages do not conform to our message style guidelines:
> you've copied an errdetail message as primary error message, but the
> rules are different for that (no complete sentences, no initial cap,
> no period).
>
> Using ERRCODE_ARRAY_ELEMENT_ERROR seems pretty random as well --- so far
> as I can see, that's generally used for cases like "this array has the
> wrong type of data elements".  Perhaps ERRCODE_PROGRAM_LIMIT_EXCEEDED
> would be the best choice.

Thank you for catching this!  I'll be more careful about error messages.


------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Startup cost of sequential scan
Next
From: Chapman Flack
Date:
Subject: Re: Proposal for disk quota feature