Re: pgsql: Indexes with INCLUDE columns and their support in B-tree - Mailing list pgsql-committers

From Alexander Korotkov
Subject Re: pgsql: Indexes with INCLUDE columns and their support in B-tree
Date
Msg-id CAPpHfdtRbE+mX9P5CYUQku=ogeVEW98SDSdiBq=4T4d36D-S_Q@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Indexes with INCLUDE columns and their support in B-tree  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Indexes with INCLUDE columns and their support in B-tree  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-committers
On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Teodor Sigaev <teodor@sigaev.ru> writes:
> Indexes with INCLUDE columns and their support in B-tree

The valgrind-using animals seem to think this broke stuff.
There are at least two different problems here:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02

I think attached patch should fix one of those problems.
We should match clauses to only key columns of index.
I will further investigate the problem with CheckIndexCompatible().

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 
Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add missing "static" markers.
Next
From: Teodor Sigaev
Date:
Subject: pgsql: Remove unused variable in non-assert-enabled build