Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree - Mailing list pgsql-committers

From Teodor Sigaev
Subject Re: pgsql: Indexes with INCLUDE columns and their support in B-tree
Date
Msg-id 95278363-d49f-a5e3-106f-d92fac547e19@sigaev.ru
Whole thread Raw
In response to Re: pgsql: Indexes with INCLUDE columns and their support in B-tree  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: pgsql: Indexes with INCLUDE columns and their support in B-tree  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-committers
Tree view 
Thank you, pushed

Alexander Korotkov wrote:
> On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us 
> <mailto:tgl@sss.pgh.pa.us>> wrote:
> 
>     Teodor Sigaev <teodor@sigaev.ru <mailto:teodor@sigaev.ru>> writes:
>     > Indexes with INCLUDE columns and their support in B-tree
> 
>     The valgrind-using animals seem to think this broke stuff.
>     There are at least two different problems here:
> 
>     https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02
>     <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02>
> 
> 
> I think attached patch should fix one of those problems.
> We should match clauses to only key columns of index.
> I will further investigate the problem with CheckIndexCompatible().
> 
> ------
> Alexander Korotkov
> Postgres Professional:http://www.postgrespro.com 
> <http://www.postgrespro.com/>
> The Russian Postgres Company

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/

pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: pgsql: match_clause_to_index should check only key columns
Next
From: Tom Lane
Date:
Subject: pgsql: Replace our traditional initial-catalog-data format with abette