Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] PinBuffer() no longer makes use of strategy - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: [HACKERS] PinBuffer() no longer makes use of strategy
Date
Msg-id CAPpHfdsckXE51mEM_n3x4Sd1b5+Y_QisrRZRzcxD+-2LAAYgPg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] PinBuffer() no longer makes use of strategy  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Tree view
On Mon, Mar 20, 2017 at 6:09 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
      if (buf->usage_count < BM_MAX_USAGE_COUNT)
      if (BUF_STATE_GET_USAGECOUNT(buf_state) != BM_MAX_USAGE_COUNT)

    being prone to paranoia, I prefer the first, but I've seen both styles in
    the code so I don't know if it's worth futzing with.


Ok, let's be paranoic and do this same way as before.  Revised patch is attached.

I see the change was done in 9.6 release cycle in commit 48354581a49c30f5757c203415aa8412d85b0f70 at April, 10. Does it mean the fix should be backpatched too?

I think so.  This patch reverts unintentional change and can be considered as bug fix.
BTW, sorry for unicode filename in previous letter.
Patch with normal ASCII name is attached.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 
Attachment

pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)
Next
From: Stephen Frost
Date:
Subject: Re: [HACKERS] Our feature change policy