Re: Obsolete comment in ExecInsert() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Obsolete comment in ExecInsert()
Date
Msg-id CAPmGK16AbwWZsyTc3jtsy+Z10n35myT3j=Cjii+f2gieeGMgnw@mail.gmail.com
Whole thread Raw
In response to Re: Obsolete comment in ExecInsert()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On Wed, Sep 28, 2022 at 11:42 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> > I think the “or a tuple has come for a different relation than that
> > for the accumulated tuples" part in the comment is a leftover from an
> > earlier version of the patch [1].  As the code shows, we do not handle
> > that case anymore, so I think we should remove that part from the
> > comment.  Attached is a patch for that.
>
> +1, but what remains still seems awkwardly worded.  How about something
> like "When we've reached the desired batch size, perform the insertion"?

+1 for that change.  Pushed that way.

Thanks for reviewing!

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: [patch] Adding an assertion to report too long hash table name
Next
From: Polina Bungina
Date:
Subject: Re: pg_rewind WAL segments deletion pitfall