Hi,
On Wed, Sep 28, 2022 at 11:42 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> > I think the “or a tuple has come for a different relation than that
> > for the accumulated tuples" part in the comment is a leftover from an
> > earlier version of the patch [1]. As the code shows, we do not handle
> > that case anymore, so I think we should remove that part from the
> > comment. Attached is a patch for that.
>
> +1, but what remains still seems awkwardly worded. How about something
> like "When we've reached the desired batch size, perform the insertion"?
+1 for that change. Pushed that way.
Thanks for reviewing!
Best regards,
Etsuro Fujita