Re: Obsolete comment in ExecInsert() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Obsolete comment in ExecInsert()
Date
Msg-id 3946130.1664376141@sss.pgh.pa.us
Whole thread Raw
In response to Obsolete comment in ExecInsert()  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: Obsolete comment in ExecInsert()
List pgsql-hackers
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> I think the “or a tuple has come for a different relation than that
> for the accumulated tuples" part in the comment is a leftover from an
> earlier version of the patch [1].  As the code shows, we do not handle
> that case anymore, so I think we should remove that part from the
> comment.  Attached is a patch for that.

+1, but what remains still seems awkwardly worded.  How about something
like "When we've reached the desired batch size, perform the insertion"?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melih Mutlu
Date:
Subject: Re: Summary function for pg_buffercache
Next
From: Bharath Rupireddy
Date:
Subject: Move backup-related code to xlogbackup.c/.h