Postgres Pro
Downloads
Home   >   mailing lists

postgres_fdw: Useless if-test in GetConnection() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject postgres_fdw: Useless if-test in GetConnection()
Date
Msg-id CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM+BLWEAhZ_AqQ@mail.gmail.com
Whole thread Raw
Responses Re: postgres_fdw: Useless if-test in GetConnection()  (Richard Guo <guofenglinux@gmail.com>)
Re: postgres_fdw: Useless if-test in GetConnection()  (Daniel Gustafsson <daniel@yesql.se>)
Re: postgres_fdw: Useless if-test in GetConnection()  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

While working on something else, I noticed that the “if (entry->conn
== NULL)” test after doing disconnect_pg_server() when re-establishing
a given connection in GetConnection() is pointless, because the former
function ensures that entry->conn is NULL.  So I removed the if-test.
Attached is a patch for that.  I think we could instead add an
assertion, but I did not, because we already have it in
make_new_connection().

This would be harmless, so I am planning to apply the patch to HEAD only.

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Melih Mutlu
Date:
Subject: Re: Allow logical replication to copy tables in binary format
Next
From: Peter Eisentraut
Date:
Subject: Re: TAP output format in pg_regress