Re: Allow logical replication to copy tables in binary format - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Allow logical replication to copy tables in binary format
Date
Msg-id CAGPVpCQSZkHDmaOhP2YtG+t24K_=wFsRkHqw+6TbvJW+0Tc+ew@mail.gmail.com
Whole thread Raw
In response to Re: Allow logical replication to copy tables in binary format  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Allow logical replication to copy tables in binary format  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers

Amit Kapila <amit.kapila16@gmail.com>, 15 Mar 2023 Çar, 12:31 tarihinde şunu yazdı:
On Tue, Mar 14, 2023 at 4:32 PM Melih Mutlu <m.melihmutlu@gmail.com> wrote:
 
What purpose does this test serve w.r.t this patch? Before checking
the sync for different column orders, the patch has already changed
binary to false, so it doesn't seem to test the functionality of this
patch. Am, I missing something?

I missed that binary has changed to false before testing column orders. I moved that test case up before changing binary to false.
Please see v14 [1].


Thanks,
--
Melih Mutlu
Microsoft

pgsql-hackers by date:

Previous
From: Melih Mutlu
Date:
Subject: Re: Allow logical replication to copy tables in binary format
Next
From: Etsuro Fujita
Date:
Subject: postgres_fdw: Useless if-test in GetConnection()