Postgres Pro
Downloads
Home   >   mailing lists

Re: postgres_fdw: batch inserts vs. before row triggers - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: postgres_fdw: batch inserts vs. before row triggers
Date
Msg-id CAPmGK15onjpkn08k=TNvEuB2BR3_TaLTuH=DE9caFuCPghKzgg@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: batch inserts vs. before row triggers  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: postgres_fdw: batch inserts vs. before row triggers
List pgsql-hackers
Tree view 
On Wed, Aug 3, 2022 at 2:24 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> To fix, I modified postgresGetForeignModifyBatchSize() to disable
> batch insert when there are any such constraints, like when there are
> any AFTER ROW triggers on the foreign table.  Attached is a patch for
> that.
>
> If there are no objections, I'll commit the patch.

Pushed after modifying the patch a bit so that in that function the
WCO test in the if test is done before the trigger test, as the former
would be cheaper than the latter.

Best regards,
Etsuro Fujita

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Patch to address creation of PgStat* contexts with null parent context
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Patch to address creation of PgStat* contexts with null parent context