Re: postgres_fdw: batch inserts vs. before row triggers - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: postgres_fdw: batch inserts vs. before row triggers
Date
Msg-id CAPmGK14iHt3u4YkCGYKuPRJz80cmSmeakjskS36rZ7ZypgcNxA@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: batch inserts vs. before row triggers  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: postgres_fdw: batch inserts vs. before row triggers  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Hi,

On Tue, Apr 19, 2022 at 9:00 PM Tomas Vondra
<tomas.vondra@enterprisedb.com> wrote:
> On 4/19/22 11:16, Etsuro Fujita wrote:
> > On Sun, Apr 17, 2022 at 6:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >> So I think we should disable batch insert in such cases, just as we
> >> disable multi insert when there are any before row triggers on the
> >> target (local) tables/partitions in copyfrom.c.  Attached is a patch
> >> for that.
> >
> > If there are no objections from Tomas or anyone else, I'll commit the patch.

> +1, I think it's a bug to do batch insert in this case.

Pushed and back-patched to v14, after tweaking a comment a little bit.

Thanks!

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: "bucoo@sohu.com"
Date:
Subject: Re: Re: fix cost subqueryscan wrong parallel cost
Next
From: John Naylor
Date:
Subject: Re: A qsort template