On Mon, Nov 5, 2012 at 8:48 AM, Ondrej Ivanič <ondrej.ivanic@gmail.com> wrote:
> On 5 November 2012 08:39, Chris Angelico <rosuav@gmail.com> wrote:
>> Point of random curiosity: The commit mentioned adds the following line:
>>
>> if (rinfo->reloptions && strlen(rinfo->reloptions) > 0)
>>
>> Is there a reason this isn't done as:
>>
>> if (rinfo->reloptions && *rinfo->reloptions)
>>
>> ? It seems like overkill to ascertain the string length just to find
>> out if the first character is the null terminator.
>
> My guess is to be multibyte encoding safe: UTF-16 or similar.
Oh, is your strlen function not the default C strlen, then? I'd best
not look at out-of-context patches then, heh :)
ChrisA
