Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Date
Msg-id CAP7QgmkUqymWHoiBkNnbW1zY=fgDOMyv2ruQfYHuagwuoQDhFQ@mail.gmail.com
Whole thread Raw
In response to Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls  (Nicholas White <n.j.white@gmail.com>)
Responses Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls  (Nicholas White <n.j.white@gmail.com>)
List pgsql-hackers


On Sat, Mar 23, 2013 at 3:25 PM, Nicholas White <n.j.white@gmail.com> wrote:
Thanks - I've added it here: https://commitfest.postgresql.org/action/patch_view?id=1096 .

I've also attached a revised version that makes IGNORE and RESPECT UNRESERVED keywords (following the pattern of NULLS_FIRST and NULLS_LAST).

Hm, you made another lookahead in base_yylex to make them unreserved -- looks ok, but not sure if there was no way to do it.

You might want to try byref types such as text.  It seems you need to copy the datum to save the value in appropriate memory context.  Also, try to create a view on those expressions.  I don't think it correctly preserves it.

Thanks,
--
Hitoshi Harada

pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: Page replacement algorithm in buffer cache
Next
From: Guillaume Lelarge
Date:
Subject: Re: Problem with background worker