Re: pgsql: Fix headerscheck failure in replication/worker_internal.h - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date
Msg-id CAOuzzgrSQSUYAGXjTYTKx+RsX42OzxzLdoHBEPEFQ6boJRwsqA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix headerscheck failure in replication/worker_internal.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Greetings,

On Tue, Nov 16, 2021 at 13:16 Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2021-Nov-16, Stephen Frost wrote:

> Not against possibly changing that but I don’t get the point of including
> be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI
> is possible and the reason for including be-gssapi-common.h then there’s
> other things that need to be under a ifdef, again, as in auth.c

BTW, this is exactly why my first suggestion was to add an exclusion
rule to headerscheck so that be-gssapi-common.h is not verified by that
script.  After re-reading your response, that looks like a reasonable
answer too.

Yeah, that seems better to me, though I’ve not yet had time to look deeply into any of this. 

Thanks,

Stephen

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: RecoveryInProgress() has critical side effects
Next
From: Andres Freund
Date:
Subject: Re: RecoveryInProgress() has critical side effects